lkml.org 
[lkml]   [2017]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] drbd:fix null pointer deref in _drbd_md_sync_page_io
Date
The return value of bio_alloc_drbd can be NULL and is used without
validation, which may cause null-pointer dereference, fix it.

Signed-off-by: Heloise <os@iscas.ac.cn>
---
drivers/block/drbd/drbd_actlog.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/block/drbd/drbd_actlog.c b/drivers/block/drbd/drbd_actlog.c
index 8d7bcfa..d6bb30e 100644
--- a/drivers/block/drbd/drbd_actlog.c
+++ b/drivers/block/drbd/drbd_actlog.c
@@ -151,6 +151,10 @@ static int _drbd_md_sync_page_io(struct drbd_device *device,
op_flags |= REQ_SYNC;

bio = bio_alloc_drbd(GFP_NOIO);
+ if (!bio) {
+ err = -ENOMEM;
+ return err;
+ }
bio->bi_bdev = bdev->md_bdev;
bio->bi_iter.bi_sector = sector;
err = -EIO;
--
2.1.0

\
 
 \ /
  Last update: 2017-04-26 12:01    [W:0.030 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site