Messages in this thread | | | Date | Mon, 24 Apr 2017 15:48:06 -0400 (EDT) | Subject | Re: [PATCH 1/1] net: bcmgenet: fix incorrect return value checks | From | David Miller <> |
| |
From: Pan Bian <bianpan201602@163.com> Date: Sun, 23 Apr 2017 18:01:05 +0800
> From: Pan Bian <bianpan2016@163.com> > > Function platform_get_irq() will return a negative value on errors. > However, in function bcmgenet_probe(), 0 is considered as a flag of > error. This patch fixes the bug by checking whether the return value of > platform_get_irq() is less than 0. > > Signed-off-by: Pan Bian <bianpan2016@163.com>
I'm definitely not confident enough to apply this.
On some platform zero IRQs are invalid.
There are also lots of pieces of code that check the return value "> 0" as success.
| |