Messages in this thread | | | Date | Mon, 24 Apr 2017 14:00:39 +0100 | From | Charles Keepax <> | Subject | Re: [PATCH 3/3] extcon: arizona: Use devm_kcalloc() in arizona_extcon_get_micd_configs() |
| |
On Mon, Apr 24, 2017 at 02:43:55PM +0200, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 23 Apr 2017 22:44:19 +0200 > > * A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "devm_kcalloc". > > * Replace the specification of a data structure by a pointer dereference > to make the corresponding size determination a bit safer according to > the Linux coding style convention. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > ---
Reviewed-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Actually fixes a bug on the alloc as well looks like the type was wrong before.
Thanks, Charles
| |