lkml.org 
[lkml]   [2017]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] mfd: omap-usb-tll: Fix inverted bit use for USB TLL mode
On Sat, 15 Apr 2017, Tony Lindgren wrote:

> Commit 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
> added support for USB TLL, but uses OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
> bit the wrong way. The comments in the code are correct, but the inverted
> use of OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF causes the register to be
> enabled instead of disabled unlike what the comments say.
>
> Without this change the Wrigley 3G LTE modem on droid 4 EHCI bus can
> be only pinged few times before it stops responding.
>
> Fixes: 16fa3dc75c22 ("mfd: omap-usb-tll: HOST TLL platform driver")
> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
> Cc: Keshava Munegowda <keshava_mgowda@ti.com>
> Cc: Marcel Partap <mpartap@gmx.net>
> Cc: Michael Scott <michael.scott@linaro.org>
> Cc: Roger Quadros <rogerq@ti.com>
> Cc: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/mfd/omap-usb-tll.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
> --- a/drivers/mfd/omap-usb-tll.c
> +++ b/drivers/mfd/omap-usb-tll.c
> @@ -377,8 +377,8 @@ int omap_tll_init(struct usbhs_omap_platform_data *pdata)
> * and use SDR Mode
> */
> reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE
> - | OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF
> | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE);
> + reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF;
> } else if (pdata->port_mode[i] ==
> OMAP_EHCI_PORT_MODE_HSIC) {
> /*

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2017-04-24 13:41    [W:0.094 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site