Messages in this thread Patch in this message | | | Subject | [PATCH v2 06/17] IB/mlx4: Delete an unnecessary check before kfree() in free_pv_object() | From | SF Markus Elfring <> | Date | Fri, 21 Apr 2017 20:36:05 +0200 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 21 Apr 2017 13:50:38 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: kfree(NULL) is safe and this check is probably not required
Thus fix the affected source code place.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/infiniband/hw/mlx4/mad.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c index cf33efce69d2..3caf468ca133 100644 --- a/drivers/infiniband/hw/mlx4/mad.c +++ b/drivers/infiniband/hw/mlx4/mad.c @@ -1962,10 +1962,8 @@ static int alloc_pv_object(struct mlx4_ib_dev *dev, int slave, int port, static void free_pv_object(struct mlx4_ib_dev *dev, int slave, int port) { - if (dev->sriov.demux[port - 1].tun[slave]) { - kfree(dev->sriov.demux[port - 1].tun[slave]); - dev->sriov.demux[port - 1].tun[slave] = NULL; - } + kfree(dev->sriov.demux[port - 1].tun[slave]); + dev->sriov.demux[port - 1].tun[slave] = NULL; } static int create_pv_resources(struct ib_device *ibdev, int slave, int port, -- 2.12.2
| |