Messages in this thread | | | Date | Thu, 20 Apr 2017 15:40:00 -0600 | From | Jonathan Corbet <> | Subject | Re: [PATCH v2 00/11] Documentation: Add ABI to the admin guide |
| |
On Thu, 13 Apr 2017 07:08:43 -0300 Mauro Carvalho Chehab <mchehab@s-opensource.com> wrote:
> That's the third attempt to add support for the Kernel ABI > at the Documentation's admin guide. > > The first approach was based on a generic extension that > calls a random script. This one is based on a new Sphinx > extension with adds a symbol specific for parsing ABI > symbols. > > It adds a new script (scripts/get_abi.pl) with can either > search for ABI symbols that match a regular expression or > outputs the entire documentation found inside a directory > as a ReST book.
So I've finally taken a quick look at this. I'm not quite ready to take it for 4.12 at this point, but I guess I'm running out of reasons to block it in general..:)
One question, though: is there a reason for the split between the sphinx extension and the Perl script that does the work? Could it all happen in the extension directly instead? It seems like a lot of moving parts.
Thanks,
jon
| |