lkml.org 
[lkml]   [2017]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.18 010/124] xen, fbfront: fix connecting to backend
    Date
    3.18-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Juergen Gross <jgross@suse.com>

    commit 9121b15b5628b38b4695282dc18c553440e0f79b upstream.

    Connecting to the backend isn't working reliably in xen-fbfront: in
    case XenbusStateInitWait of the backend has been missed the backend
    transition to XenbusStateConnected will trigger the connected state
    only without doing the actions required when the backend has
    connected.

    Signed-off-by: Juergen Gross <jgross@suse.com>
    Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
    Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/video/fbdev/xen-fbfront.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/video/fbdev/xen-fbfront.c
    +++ b/drivers/video/fbdev/xen-fbfront.c
    @@ -644,7 +644,6 @@ static void xenfb_backend_changed(struct
    break;

    case XenbusStateInitWait:
    -InitWait:
    xenbus_switch_state(dev, XenbusStateConnected);
    break;

    @@ -655,7 +654,8 @@ InitWait:
    * get Connected twice here.
    */
    if (dev->state != XenbusStateConnected)
    - goto InitWait; /* no InitWait seen yet, fudge it */
    + /* no InitWait seen yet, fudge it */
    + xenbus_switch_state(dev, XenbusStateConnected);

    if (xenbus_scanf(XBT_NIL, info->xbdev->otherend,
    "request-update", "%d", &val) < 0)

    \
     
     \ /
      Last update: 2017-04-20 09:08    [W:2.655 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site