Messages in this thread Patch in this message | | | Date | Wed, 19 Apr 2017 11:50:01 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH] perf, tools: Fix display of data source snoop indication |
| |
On Wed, Apr 19, 2017 at 03:46:13PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Apr 19, 2017 at 10:49:40AM -0700, Andi Kleen escreveu: > > From: Andi Kleen <ak@linux.intel.com> > > > > perf mem report doesn't display the data source snoop indication correctly. > > > > In the kernel API the definition is > > missing something?
#define PERF_MEM_SNOOP_NONE 0x02 /* no snoop */ #define PERF_MEM_SNOOP_HIT 0x04 /* snoop hit */ #define PERF_MEM_SNOOP_MISS 0x08 /* snoop miss */
> > > but the table used by the perf tools exchanged Hit and Miss > > > > "None", > > "Miss", > > "Hit", > > > > Fix the table in perf. > > > > Cc: eranian@google.com > > Signed-off-by: Andi Kleen <ak@linux.intel.com> > > --- > > tools/perf/util/mem-events.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/mem-events.c b/tools/perf/util/mem-events.c > > index 1d4ab53c60ca..865ba3c39284 100644 > > --- a/tools/perf/util/mem-events.c > > +++ b/tools/perf/util/mem-events.c > > @@ -205,8 +205,8 @@ int perf_mem__lvl_scnprintf(char *out, size_t sz, struct mem_info *mem_info) > > static const char * const snoop_access[] = { > > "N/A", > > "None", > > - "Miss", > > "Hit", > > + "Miss", > > "HitM", > > }; > > > > -- > > 2.9.3
| |