Messages in this thread | | | Subject | Re: [PATCH V3 1/4] reset: Add API to count number of reset available with device | From | Vivek Gautam <> | Date | Wed, 19 Apr 2017 17:19:04 +0530 |
| |
On 04/19/2017 03:55 PM, Philipp Zabel wrote: > On Tue, 2017-04-18 at 16:51 +0530, Vivek Gautam wrote: >> Count number of reset phandles available with the device node >> to know the resets a given device has. >> >> Cc: Philipp Zabel <p.zabel@pengutronix.de> >> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org> >> --- >> drivers/reset/core.c | 23 +++++++++++++++++++++++ >> include/linux/reset.h | 6 ++++++ >> 2 files changed, 29 insertions(+) >> >> diff --git a/drivers/reset/core.c b/drivers/reset/core.c >> index cd739d2fa160..f0a06a7aca93 100644 >> --- a/drivers/reset/core.c >> +++ b/drivers/reset/core.c >> @@ -465,3 +465,26 @@ int device_reset(struct device *dev) >> return ret; >> } >> EXPORT_SYMBOL_GPL(device_reset); >> + >> +/** >> + * of_reset_control_get_count - Count number of resets available with a device >> + * >> + * @node: device node that contains 'resets'. >> + * >> + * Returns positive reset count on success, or error number on failure and >> + * on count being zero. >> + */ >> +int of_reset_control_get_count(struct device_node *node) >> +{ >> + int count; >> + >> + if (!node) >> + return -EINVAL; >> + >> + count = of_count_phandle_with_args(node, "resets", "#reset-cells"); >> + if (count == 0) >> + count = -ENOENT; >> + >> + return count; >> +} >> +EXPORT_SYMBOL_GPL(of_reset_control_get_count); > This doesn't need to be public anymore. You can make it static and merge > it into the second patch.
Thanks for reviewing the series. Sure, make sense to make it static and squash in the second patch.
Best Regards Vivek
> > regards > Philipp >
-- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
| |