lkml.org 
[lkml]   [2017]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch V2 05/10] timer: Retrieve next expiry of pinned/non-pinned timers seperately
On Wed, 19 Apr 2017, Peter Zijlstra wrote:
> On Tue, Apr 18, 2017 at 01:11:07PM +0200, Thomas Gleixner wrote:
> > +
> > + /*
> > + * If the local queue expires first, there is no requirement for
> > + * queuing the CPU in the global expiry mechanism.
>
> The comment doesn't make sense... (maybe at this stage)

Yeah, it's only useful once the real magic is in place.

> > + */
> > + if (!local_first && !global_empty)
> > + *global_evt = basem + (nextevt_global - basej) * TICK_NSEC;
>
> I was initially thinking !local_first would have to imply !global_empty,
> but after going back and reading the previous patches again, I found
> this was not so. Still slightly surprising.

Indeed, that's confusing.

Thanks,

tglx


\
 
 \ /
  Last update: 2017-04-19 11:57    [W:0.066 / U:2.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site