lkml.org 
[lkml]   [2017]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] usb: dwc2: Remove unnecessary debug prints
From
Date
On Wed, 2017-04-19 at 15:16 +0400, Razmik Karapetyan wrote:
> Removed unnecessary debug prints about DMA mode for host side
> from dwc2_gahbcfg_init() function.

Why are these unnecessary? Are these emitted elsewhere?

and...

> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
[]
> @@ -302,22 +302,10 @@ static int dwc2_gahbcfg_init(struct dwc2_hsotg *hsotg)
[]
> if (hsotg->params.host_dma)
> ahbcfg |= GAHBCFG_DMA_EN;
> + else
> + hsotg->params.dma_desc_enable = false;

This change isn't mentioned in the commit message.
Why is is useful?

\
 
 \ /
  Last update: 2017-04-19 23:56    [W:2.335 / U:1.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site