Messages in this thread | | | Date | Tue, 18 Apr 2017 06:31:10 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry |
| |
On Mon, Apr 17, 2017 at 08:22:57PM +0200, Martin Kaiser wrote: > Set the permissions for /proc/misc to 0444 explicitly. At the moment, > we're using 0 and have proc_create_data() convert this to 0444. > This fixes a checkpatch warning. > > Signed-off-by: Martin Kaiser <martin@kaiser.cx> > --- > v2: > separate patch for each checkpatch warning > > drivers/char/misc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/misc.c b/drivers/char/misc.c > index 3447b2e..3c633d5 100644 > --- a/drivers/char/misc.c > +++ b/drivers/char/misc.c > @@ -280,7 +280,7 @@ static int __init misc_init(void) > int err; > struct proc_dir_entry *ret; > > - ret = proc_create("misc", 0, NULL, &misc_proc_fops); > + ret = proc_create("misc", 0444, NULL, &misc_proc_fops);
What checkpatch warning does this fix? 0 is a number :)
thanks,
greg k-h
| |