lkml.org 
[lkml]   [2017]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] jump_label: Provide static_key_slow_inc_nohp()
On Tue, 18 Apr 2017 15:03:50 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> +++ b/kernel/padata.c
> @@ -1008,11 +1008,10 @@ static struct padata_instance *padata_al
> * parallel workers.
> *
> * @wq: workqueue to use for the allocated padata instance
> - *
> - * Must be called from a get_online_cpus() protected region

Find the comment redundant?

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

> */
> struct padata_instance *padata_alloc_possible(struct workqueue_struct *wq)
> {
> + lockdep_assert_hotplug_held();
> return padata_alloc(wq, cpu_possible_mask, cpu_possible_mask);
> }
> EXPORT_SYMBOL(padata_alloc_possible);
> --- a/kernel/stop_machine.c
> +++ b/kernel/stop_machine.c
> @@ -561,6 +561,8 @@ int stop_machine_locked(cpu_stop_fn_t fn
> .active_cpus = cpus,
> };
>
> + lockdep_assert_hotplug_held();
> +
> if (!stop_machine_initialized) {
> /*
> * Handle the case where stop_machine() is called

\
 
 \ /
  Last update: 2017-04-18 18:48    [W:0.094 / U:1.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site