lkml.org 
[lkml]   [2017]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()
    Date
    The call to of_find_node_by_path("/cpus") returns the cpus device_node
    with its reference count incremented. There is no matching of_node_put()
    call in of_numa_parse_cpu_nodes() which results in a leaked reference
    to the "/cpus" node.

    This patch adds an of_node_put() to release the reference.

    fixes: 298535c00a2c ("of, numa: Add NUMA of binding implementation.")
    Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
    ---
    drivers/of/of_numa.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c
    index a53982a..2db1f7a 100644
    --- a/drivers/of/of_numa.c
    +++ b/drivers/of/of_numa.c
    @@ -57,6 +57,8 @@ static void __init of_numa_parse_cpu_nodes(void)
    else
    node_set(nid, numa_nodes_parsed);
    }
    +
    + of_node_put(cpus);
    }

    static int __init of_numa_parse_memory_nodes(void)
    --
    1.8.3.1
    \
     
     \ /
      Last update: 2017-04-18 02:30    [W:4.061 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site