lkml.org 
[lkml]   [2017]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] backlight: pwm_bl: Fix condition to set enable gpio as output
Hi Paul,

On Mon, Apr 17, 2017 at 5:38 PM, Paul Kocialkowski <contact@paulk.fr> wrote:
> Le dimanche 16 avril 2017 à 22:55 +0200, Geert Uytterhoeven a écrit :
>> On Sun, Apr 16, 2017 at 12:35 PM, Paul Kocialkowski <contact@paulk.fr> wrote:
>> > The move to a dedicated pwm_backlight_initial_power_state function in
>> > commit 7613c922315e308a6486d802abed2eb74443dffd modified the condition
>> > to set the enable gpio as output. This breaks specific use cases using
>> > that GPIO, such as tegra124-based nyan Chromebooks where backlight
>> > stopped working.
>> >
>> > This puts the condition back to the way it was before the move.
>> >
>> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
>>
>> Does "[PATCH v2] backlight: pwm_bl: Fix GPIO out for unimplemented
>> .get_direction()"
>> (https://lkml.org/lkml/2017/4/4/225) fix your issue?
>
> This definitely solves the issue!
>
> Since this fixes broken backlight (that, in turn, makes systems unusable),
> perhaps this should be included in the next rc cycle?

You mean v4.11 final, as there probably won't be another rc?
Yes!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2017-04-17 21:58    [W:0.060 / U:0.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site