lkml.org 
[lkml]   [2017]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 21/25] net: pxa168_eth: Use kcalloc() in two functions
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 17 Apr 2017 14:32:14 +0200

    Multiplications for the size determination of memory allocations
    indicated that array data structures should be processed.
    Thus use the corresponding function "kcalloc".

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/net/ethernet/marvell/pxa168_eth.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c
    index 28cb36d9e50a..2404eac51c63 100644
    --- a/drivers/net/ethernet/marvell/pxa168_eth.c
    +++ b/drivers/net/ethernet/marvell/pxa168_eth.c
    @@ -1036,8 +1036,7 @@ static int rxq_init(struct net_device *dev)
    int rx_desc_num = pep->rx_ring_size;

    /* Allocate RX skb rings */
    - pep->rx_skb = kzalloc(sizeof(*pep->rx_skb) * pep->rx_ring_size,
    - GFP_KERNEL);
    + pep->rx_skb = kcalloc(rx_desc_num, sizeof(*pep->rx_skb), GFP_KERNEL);
    if (!pep->rx_skb)
    return -ENOMEM;

    @@ -1096,8 +1095,7 @@ static int txq_init(struct net_device *dev)
    int size = 0, i = 0;
    int tx_desc_num = pep->tx_ring_size;

    - pep->tx_skb = kzalloc(sizeof(*pep->tx_skb) * pep->tx_ring_size,
    - GFP_KERNEL);
    + pep->tx_skb = kcalloc(tx_desc_num, sizeof(*pep->tx_skb), GFP_KERNEL);
    if (!pep->tx_skb)
    return -ENOMEM;

    --
    2.12.2
    \
     
     \ /
      Last update: 2017-04-17 17:31    [W:5.041 / U:0.360 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site