Messages in this thread | | | Date | Mon, 17 Apr 2017 10:59:47 -0400 (EDT) | Subject | Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling | From | David Miller <> |
| |
From: Wolfgang Bumiller <w.bumiller@proxmox.com> Date: Wed, 12 Apr 2017 16:21:38 +0200
> Commit 1045ba77a ("net sched actions: Add support for user cookies") > added code to net/sched/act_api.c's tcf_action_init_1 using the `tb` > nlattr array unconditionally, while it was otherwise used as well as > initialized only when `name == NULL`: ... > I'm not sure why the TC_ACT_COOKIE code was added to tcf_action_init_1 > where it is now. It makes me think that it's supposed to be available > universally, but the `name == NULL` check for how nla is used or passed > to ->init() shows that the there are various different TC_ACT_* enums in > use at this point, hence the 'RFC' part of the patches, I'm not that > familiar with the code yet.
Jamal please review this.
| |