lkml.org 
[lkml]   [2017]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] scsi: storvsc: Prefer kcalloc over kzalloc with multiply
Date


> -----Original Message-----
> From: Miguel Bernal Marin [mailto:miguel.bernal.marin@linux.intel.com]
> Sent: Wednesday, March 15, 2017 11:58 PM
> To: KY Srinivasan <kys@microsoft.com>; Martin K. Petersen
> <martin.petersen@oracle.com>
> Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org;
> devel@linuxdriverproject.org; Haiyang Zhang <haiyangz@microsoft.com>;
> Stephen Hemminger <sthemmin@microsoft.com>; James E.J. Bottomley
> <jejb@linux.vnet.ibm.com>
> Subject: [PATCH] scsi: storvsc: Prefer kcalloc over kzalloc with multiply
>
> Use kcalloc for allocating an array instead of kzalloc with multiply,
> kcalloc is the preferred API.
>
> Found with checkpatch.
>
> Signed-off-by: Miguel Bernal Marin <miguel.bernal.marin@linux.intel.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>


> ---
> drivers/scsi/storvsc_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 638e5f427c90..3d70d1cf49a3 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -866,7 +866,7 @@ static int storvsc_channel_init(struct hv_device
> *device, bool is_fc)
> * We will however populate all the slots to evenly distribute
> * the load.
> */
> - stor_device->stor_chns = kzalloc(sizeof(void *) *
> num_possible_cpus(),
> + stor_device->stor_chns = kcalloc(num_possible_cpus(), sizeof(void
> *),
> GFP_KERNEL);
> if (stor_device->stor_chns == NULL)
> return -ENOMEM;
> --
> 2.12.0

\
 
 \ /
  Last update: 2017-04-14 01:29    [W:0.038 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site