Messages in this thread | | | Subject | Re: [PATCH V14 02/10] ras: acpi/apei: cper: generic error data entry v3 per ACPI 6.1 | From | "Baicar, Tyler" <> | Date | Thu, 13 Apr 2017 15:33:13 -0600 |
| |
On 4/13/2017 2:47 PM, Borislav Petkov wrote: > On Thu, Apr 13, 2017 at 02:30:21PM -0600, Baicar, Tyler wrote: >> I do not agree with this. The struct being passed to this function is >> already named acpi_hest_generic_data in the existing code and all over this >> code is named gdata not just d. > And I'm saying they're too long - the preexisting ones and the ones > you're adding - and impair readability. This whole driver is one > unreadable ugly pile and if I were the maintainer I would never allowed > it in its current form. > > But I don't think it really has a maintainer - poor Rafael has to deal > with it because it is under drivers/acpi/ and that whole RAS firmware > crap got thrown over the wall at some point and now we're stuck with it. > > So this is just my opinion since he asked me to take a look. Okay, that makes sense. I'd prefer to avoid completely re-writing the existing code in this patch set :)
Thanks, Tyler
-- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |