lkml.org 
[lkml]   [2017]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH tip/core/rcu 07/40] rcu: Semicolon inside RCU_TRACE() for tree.c
    Date
    The current use of "RCU_TRACE(statement);" can cause odd bugs, especially
    where "statement" is a local-variable declaration, as it can leave a
    misplaced ";" in the source code. This commit therefore converts these
    to "RCU_TRACE(statement;)", which avoids the misplaced ";".

    Reported-by: Josh Triplett <josh@joshtriplett.org>
    Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    ---
    kernel/rcu/tree.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
    index df8f6401f2d5..e8843bf0f5e1 100644
    --- a/kernel/rcu/tree.c
    +++ b/kernel/rcu/tree.c
    @@ -2793,14 +2793,14 @@ static void rcu_adopt_orphan_cbs(struct rcu_state *rsp, unsigned long flags)
    */
    static void rcu_cleanup_dying_cpu(struct rcu_state *rsp)
    {
    - RCU_TRACE(unsigned long mask);
    - RCU_TRACE(struct rcu_data *rdp = this_cpu_ptr(rsp->rda));
    - RCU_TRACE(struct rcu_node *rnp = rdp->mynode);
    + RCU_TRACE(unsigned long mask;)
    + RCU_TRACE(struct rcu_data *rdp = this_cpu_ptr(rsp->rda);)
    + RCU_TRACE(struct rcu_node *rnp = rdp->mynode;)

    if (!IS_ENABLED(CONFIG_HOTPLUG_CPU))
    return;

    - RCU_TRACE(mask = rdp->grpmask);
    + RCU_TRACE(mask = rdp->grpmask;)
    trace_rcu_grace_period(rsp->name,
    rnp->gpnum + 1 - !!(rnp->qsmask & mask),
    TPS("cpuofl"));
    --
    2.5.2
    \
     
     \ /
      Last update: 2017-04-12 19:40    [W:4.411 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site