Messages in this thread | | | Date | Wed, 12 Apr 2017 10:32:28 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v1]] lib/btree.c: optimise the code by previously getpos function |
| |
On Wed, Apr 12, 2017 at 06:03:10PM +0800, Leno Hou wrote: > 1. Actually, this is cleanup of the code to human being read but not > optimize. And When I compiled the kernel > and checked with object code . It proved as same as before. So it's no > need to test this change. > > 2. This Simple B+ Tree in Memory was used by SCSI driver QLA2XXX. so it > would be better to merge this > cleanup for future optimize. Thanks.
If you care about the btree code a good first step would be to write a test suite instead of micro-optimizing it out of the blue without actually being able to test it.
| |