Messages in this thread | | | From | Carlo Caione <> | Date | Wed, 12 Apr 2017 10:50:16 +0200 | Subject | Re: [PATCH v3] HID: asus: support backlight on USB keyboards |
| |
On Mon, Apr 10, 2017 at 8:39 AM, Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote: > On Apr 06 2017 or thereabouts, Carlo Caione wrote:
>> + ret = devm_led_classdev_register(&hdev->dev, &drvdata->kbd_backlight->cdev); >> + if (ret < 0) { >> + /* No need to have this still around */ >> + devm_kfree(&hdev->dev, drvdata->kbd_backlight); >> + cancel_work_sync(&drvdata->kbd_backlight->work); > > Small nitpick, you don't need to call cancel_work_sync() here, nobody > could have called a worker. But OTOH, it doesn't hurt. > > Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Thanks Benjamin. Who should pick this up?
-- Carlo Caione | +39.340.80.30.096 | Endless
| |