lkml.org 
[lkml]   [2017]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3] HID: asus: support backlight on USB keyboards
On Mon, Apr 10, 2017 at 8:39 AM, Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:
> On Apr 06 2017 or thereabouts, Carlo Caione wrote:

>> + ret = devm_led_classdev_register(&hdev->dev, &drvdata->kbd_backlight->cdev);
>> + if (ret < 0) {
>> + /* No need to have this still around */
>> + devm_kfree(&hdev->dev, drvdata->kbd_backlight);
>> + cancel_work_sync(&drvdata->kbd_backlight->work);
>
> Small nitpick, you don't need to call cancel_work_sync() here, nobody
> could have called a worker. But OTOH, it doesn't hurt.
>
> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Thanks Benjamin. Who should pick this up?

--
Carlo Caione | +39.340.80.30.096 | Endless

\
 
 \ /
  Last update: 2017-04-12 10:51    [W:0.057 / U:3.020 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site