[lkml]   [2017]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch 0/6] hwmon/coretemp: Hotplug fixes, cleanups and state machine conversion
2016-11-23 17:28 GMT+02:00 Guenter Roeck <>:
> On 11/22/2016 09:42 AM, Thomas Gleixner wrote:
>> After the first attempt to convert the coretemp driver to the hotplug state
>> machine failed, we had a deeper look and went a bit farther.
>> The driver has quite some interesting concepts vs. the package, core and
>> sysfs file management and a bug in the package temperature sysfs interface
>> vs. cpu hotplug.
>> The following series fixes that bug and simplifies the package/core
>> management and at the end converts it to the hotplug state machine.
>> Along with the source size the binary size shrinks as well:
>> text data bss dec hex
>> 4068 360 20 4448 1160 Before
>> 3801 180 36 4017 fb1 After
>> Thanks,
>> tglx
>> -----
>> coretemp.c | 321 +++++++++++++++++++++----------------------------------------
>> 1 file changed, 113 insertions(+), 208 deletions(-)


Resume-from-suspend stopped working in HP xw6600 in fedora kernel
4.10.8-200.fc25.x86_64, while it worked just fine in

When powering on the suspended PC, there is no video output, and to
recover, I need to reset the machine.
Nothing is recorded in the journal logs for the resume, last lines are
from the suspend:

Apr 08 15:41:49 xw6600 systemd[1]: Reached target Sleep.
Apr 08 15:41:49 xw6600 systemd[1]: Starting Suspend...
Apr 08 15:41:49 xw6600 systemd-sleep[6675]: Suspending system...

Also tested 4.11-rc5, but it fails the same way.

Bisection leads to commit:

commit e00ca5df37adc68052ea699cbd010ee4e19e39e4
Author: Thomas Gleixner <>
Date: Tue Nov 22 17:42:04 2016 +0000

hwmon: (coretemp) Convert to hotplug state machine

Install the callbacks via the state machine. Setup and teardown are handled
by the hotplug core.

Signed-off-by: Sebastian Andrzej Siewior <>
Cc: Fenghua Yu <>
Cc: Jean Delvare <>
Cc: Guenter Roeck <>
Signed-off-by: Guenter Roeck <>

If I do "modprobe -r coretemp", then the resume works OK with

Any ideas?

4.9.9-200.fc25.x86_64 dmesg:

4.10.8-200.fc25.x86_64 dmesg:


 \ /
  Last update: 2017-04-12 10:32    [W:0.090 / U:68.952 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site