Messages in this thread | | | Subject | Re: [PATCH 1/2] firmware: Google VPD: import lib_vpd source files | From | Thierry Escande <> | Date | Tue, 11 Apr 2017 16:28:45 +0200 |
| |
Hi Greg
On 11/04/2017 16:09, Greg Kroah-Hartman wrote: > On Tue, Apr 11, 2017 at 11:14:30AM +0200, Thierry Escande wrote: >> +#include <linux/export.h> >> + >> +#include "vpd_decode.h" >> + >> +static int decode_len(const int32_t max_len, const uint8_t *in, >> + int32_t *length, int32_t *decoded_len) >> +{ >> + uint8_t more; > > Care to use "real" kernel variable types please? u8, u16, and others > are you friend, uint8_t really isn't what we prefer, and checkpatch > should tell you that...
By default checkpatch doesn't warn about types unless --strict is specified... Sorry about that.
Regards, Thierry
| |