lkml.org 
[lkml]   [2017]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support
Date
Hi Andrew,

On Friday 07 April 2017 15:40:07 Andrew Lunn wrote:
> > +Optional properties:
> > +
> > +- reset-gpios: GPIO to be used to reset the whole device, always low
> > active
>
> I would avoid the always low active comment. The input to the switch
> is active low. But i've seen designs with an inverter in the reset
> path, so from the perspective of the GPIO it would be active high. The
> device tree binding allows for this, via the flags. And since you use
> the gpiod API, it should all just work.
>
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port@0 { /* RMII fixed link to master */
> > + reg = <0>;
> > + label = "cpu";
> > + ethernet = <&master>;
> > + };
> > +
> > + port@1 { /* external port 1 */
> > + compatible = "ethernet-phy-ieee802.3-c22";
> > + reg = <1>;
> > + label = "lan1;
> > + };
>
> These are not PHY nodes, so does this compatible string do anything?

I removed them and nothing changed.

Regards,
Juergen

--
Pengutronix e.K.                             | Juergen Borleis             |
Industrial Linux Solutions                  | http://www.pengutronix.de/  |

\
 
 \ /
  Last update: 2017-04-10 10:00    [W:0.068 / U:29.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site