Messages in this thread | | | Date | Mon, 10 Apr 2017 09:44:57 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v3 1/1] perf tools: fix perf build with ARCH=x86_64 |
| |
On Sun, Apr 09, 2017 at 07:43:15PM -0700, Jiada Wang wrote: > Hello Jiri > > On 04/09/2017 10:27 AM, Jiri Olsa wrote: > > On Tue, Apr 04, 2017 at 11:25:44PM -0700, jiada_wang@mentor.com wrote: > > > From: Jiada Wang<jiada_wang@mentor.com> > > > > > > with commit: 0a943cb10ce78 (tools build: Add HOSTARCH Makefile variable) > > > the following build failure is seen when build with ARCH=x86_64 > > is that described somewhere as a valid building interface? > > I never use it so I have no idea.. would you describe your > > build env/process? > I used "ARCH=x86_64 make -C tools perf V=1" to build perf for x86_64 ARCH.
you're on x86 machine right? I don't see CROSS_COMPILE being used..
what's the purpose of the ARCH var setup then?
> > > > In file included from util/event.c:2:0: > > > tools/include/uapi/linux/mman.h:4:27: fatal error: uapi/asm/mman.h: No such file or directory > > > compilation terminated. > > > > > > fix this issue by use SRCARCH instead of ARCH in perf. > > please describe also the the issue itself in the changelog, not just the fix > I will update changelog with detail information about the issue in v4 > > > > > > so objtool is using SRCARCH this way, I guess it's fine > > > > if we go this way, you also need to change the pmu-events/Build > > and there's some comment using $(ARCH) in util/header.c > will update pmu-events/Build in v4
I'll check
thanks, jirka
| |