[lkml]   [2017]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 3.12 018/142] USB: serial: omninet: fix reference leaks at open
From: Johan Hovold <>

3.12-stable review patch. If anyone has any objections, please let me know.


commit 30572418b445d85fcfe6c8fe84c947d2606767d8 upstream.

This driver needlessly took another reference to the tty on open, a
reference which was then never released on close. This lead to not just
a leak of the tty, but also a driver reference leak that prevented the
driver from being unloaded after a port had once been opened.

Fixes: 4a90f09b20f4 ("tty: usb-serial krefs")
Signed-off-by: Johan Hovold <>
Signed-off-by: Jiri Slaby <>
drivers/usb/serial/omninet.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/usb/serial/omninet.c b/drivers/usb/serial/omninet.c
index 24720f656387..8028e5ffe80d 100644
--- a/drivers/usb/serial/omninet.c
+++ b/drivers/usb/serial/omninet.c
@@ -143,12 +143,6 @@ static int omninet_port_remove(struct usb_serial_port *port)

static int omninet_open(struct tty_struct *tty, struct usb_serial_port *port)
- struct usb_serial *serial = port->serial;
- struct usb_serial_port *wport;
- wport = serial->port[1];
- tty_port_tty_set(&wport->port, tty);
return usb_serial_generic_open(tty, port);

 \ /
  Last update: 2017-04-10 18:15    [W:0.502 / U:5.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site