lkml.org 
[lkml]   [2017]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 3/3] thermal: int340x: Use kcalloc() in int340x_thermal_zone_add()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Mon, 10 Apr 2017 21:56:58 +0200

    A multiplication for the size determination of a memory allocation
    indicated that an array data structure should be processed.
    Thus use the corresponding function "kcalloc".

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/thermal/int340x_thermal/int340x_thermal_zone.c | 7 ++++---
    1 file changed, 4 insertions(+), 3 deletions(-)

    diff --git a/drivers/thermal/int340x_thermal/int340x_thermal_zone.c b/drivers/thermal/int340x_thermal/int340x_thermal_zone.c
    index 145a5c53ff5c..a611f3367168 100644
    --- a/drivers/thermal/int340x_thermal/int340x_thermal_zone.c
    +++ b/drivers/thermal/int340x_thermal/int340x_thermal_zone.c
    @@ -239,9 +239,10 @@ struct int34x_thermal_zone *int340x_thermal_zone_add(struct acpi_device *adev,
    if (ACPI_FAILURE(status))
    trip_cnt = 0;
    else {
    - int34x_thermal_zone->aux_trips = kzalloc(
    - sizeof(*int34x_thermal_zone->aux_trips) *
    - trip_cnt, GFP_KERNEL);
    + int34x_thermal_zone->aux_trips
    + = kcalloc(trip_cnt,
    + sizeof(*int34x_thermal_zone->aux_trips),
    + GFP_KERNEL);
    if (!int34x_thermal_zone->aux_trips) {
    ret = -ENOMEM;
    goto err_trip_alloc;
    --
    2.12.2
    \
     
     \ /
      Last update: 2017-04-10 22:21    [W:2.044 / U:9.436 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site