lkml.org 
[lkml]   [2017]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 15/19] HID: hid-input: Add parentheses to quell gcc warning
    3.16.43-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: James C Boyd <jcboyd.dev@gmail.com>

    commit 09a5c34e8d6b05663ec4c3d22b1fbd9fec89aaf9 upstream.

    GCC reports a -Wlogical-not-parentheses warning here; therefore
    add parentheses to shut it up and to express our intent more.

    Signed-off-by: James C Boyd <jcboyd.dev@gmail.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    Cc: Arnd Bergmann <arnd@arndb.de>
    ---
    drivers/hid/hid-input.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/hid/hid-input.c
    +++ b/drivers/hid/hid-input.c
    @@ -1119,7 +1119,7 @@ void hidinput_hid_event(struct hid_devic
    return;

    /* report the usage code as scancode if the key status has changed */
    - if (usage->type == EV_KEY && !!test_bit(usage->code, input->key) != value)
    + if (usage->type == EV_KEY && (!!test_bit(usage->code, input->key)) != value)
    input_event(input, EV_MSC, MSC_SCAN, usage->hid);

    input_event(input, usage->type, usage->code, value);
    \
     
     \ /
      Last update: 2017-04-01 15:25    [W:5.211 / U:0.480 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site