Messages in this thread Patch in this message | | | From | Ben Hutchings <> | Date | Sat, 01 Apr 2017 14:17:50 +0100 | Subject | [PATCH 3.16 15/19] HID: hid-input: Add parentheses to quell gcc warning |
| |
3.16.43-rc1 review patch. If anyone has any objections, please let me know.
------------------
From: James C Boyd <jcboyd.dev@gmail.com>
commit 09a5c34e8d6b05663ec4c3d22b1fbd9fec89aaf9 upstream.
GCC reports a -Wlogical-not-parentheses warning here; therefore add parentheses to shut it up and to express our intent more.
Signed-off-by: James C Boyd <jcboyd.dev@gmail.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz> Signed-off-by: Ben Hutchings <ben@decadent.org.uk> Cc: Arnd Bergmann <arnd@arndb.de> --- drivers/hid/hid-input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -1119,7 +1119,7 @@ void hidinput_hid_event(struct hid_devic return; /* report the usage code as scancode if the key status has changed */ - if (usage->type == EV_KEY && !!test_bit(usage->code, input->key) != value) + if (usage->type == EV_KEY && (!!test_bit(usage->code, input->key)) != value) input_event(input, EV_MSC, MSC_SCAN, usage->hid); input_event(input, usage->type, usage->code, value);
| |