lkml.org 
[lkml]   [2017]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/9] mm: fix mapping_set_error call in me_pagecache_dirty
    Date
    The error code should be negative. Since this ends up in the default
    case anyway, this is harmless, but it's less confusing to negate it.

    Signed-off-by: Jeff Layton <jlayton@redhat.com>
    ---
    mm/memory-failure.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/mm/memory-failure.c b/mm/memory-failure.c
    index 27f7210e7fab..4b56e53e5378 100644
    --- a/mm/memory-failure.c
    +++ b/mm/memory-failure.c
    @@ -674,7 +674,7 @@ static int me_pagecache_dirty(struct page *p, unsigned long pfn)
    * the first EIO, but we're not worse than other parts
    * of the kernel.
    */
    - mapping_set_error(mapping, EIO);
    + mapping_set_error(mapping, -EIO);
    }

    return me_pagecache_clean(p, pfn);
    --
    2.9.3
    \
     
     \ /
      Last update: 2017-03-08 17:39    [W:2.621 / U:0.384 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site