lkml.org 
[lkml]   [2017]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] dmaengine: rcar-dmac: enable descriptor mode on 40bit
Date

Hi Laurent

Thank you for your review

> > +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
> > + if (i == 0) {
> > + high_src_addr = chunk->src_addr >> 32;
> > + high_dst_addr = chunk->dst_addr >> 32;
> > + }
>
> This will be triggered for every iteration of the while loop, so if one sg
> entry crosses a 32-bit boundary, you won't detect it.
>
> I know it will mean one additional #ifdef, but I think you should move that
> code out of the while loop as I previously proposed.

Grr indeed. Thank you for pointing it.
Hmm.. OK, I will add +1 #ifdef

Best regards
---
Kuninori Morimoto

\
 
 \ /
  Last update: 2017-03-08 01:23    [W:0.055 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site