Messages in this thread | | | Date | Mon, 6 Mar 2017 22:02:38 +0100 | From | Boris Brezillon <> | Subject | Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the nvmem API |
| |
On Mon, 6 Mar 2017 20:03:28 +0100 Richard Weinberger <richard@nod.at> wrote:
> Am 06.03.2017 um 18:21 schrieb Alban: > > On Fri, 3 Mar 2017 23:21:29 +0100 > > Richard Weinberger <richard@nod.at> wrote: > > > >> Am 03.03.2017 um 15:11 schrieb Boris Brezillon: > >>>> And add a list of successfully added notifiers, along with their > >>>> data pointer, to the MTD device. That's simple and would also remove > >>>> the need for notifier to have a private list of their instances as I > >>>> had to do here. > >>> > >>> And then you're abusing the notifier concept. As said earlier, a > >>> notifier is not necessarily using the device, and thus, don't > >>> necessarily need private data. > >>> It's not only about what is the simplest solution for your use case, > >>> but also what other users want/need. > >> > >> Yes, please don't use the mtd_notifier. > >> I strongly vote to embed the nvmem pointer into struct mtd_info. > > > > Ok, I'll do that. However it mean it will have to stays in > > drivers/mtd as it then become part of the MTD core. > > Brian, are you fine with this?
Same question to Srinivas.
| |