| From | Jiri Slaby <> | Subject | [PATCH 3.12 065/113] vfs: fix uninitialized flags in splice_to_pipe() | Date | Mon, 6 Mar 2017 10:11:29 +0100 |
| |
From: Miklos Szeredi <mszeredi@redhat.com>
3.12-stable review patch. If anyone has any objections, please let me know.
===============
commit 5a81e6a171cdbd1fa8bc1fdd80c23d3d71816fac upstream.
Flags (PIPE_BUF_FLAG_PACKET, PIPE_BUF_FLAG_GIFT) could remain on the unused part of the pipe ring buffer. Previously splice_to_pipe() left the flags value alone, which could result in incorrect behavior.
Uninitialized flags appears to have been there from the introduction of the splice syscall.
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Jiri Slaby <jslaby@suse.cz> --- fs/splice.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/fs/splice.c b/fs/splice.c index 51ce51b9af6a..2e012472f97b 100644 --- a/fs/splice.c +++ b/fs/splice.c @@ -215,6 +215,7 @@ ssize_t splice_to_pipe(struct pipe_inode_info *pipe, buf->len = spd->partial[page_nr].len; buf->private = spd->partial[page_nr].private; buf->ops = spd->ops; + buf->flags = 0; if (spd->flags & SPLICE_F_GIFT) buf->flags |= PIPE_BUF_FLAG_GIFT; -- 2.12.0
|