lkml.org 
[lkml]   [2017]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap interface
On Tue, Mar 28, 2017 at 03:45:43PM +0100, Lorenzo Pieralisi wrote:
> On Mon, Mar 27, 2017 at 08:41:10PM -0500, Bjorn Helgaas wrote:
> > On Mon, Mar 27, 2017 at 10:49:30AM +0100, Lorenzo Pieralisi wrote:

> > > #define ioremap_uc ioremap_uc
> > > +#define ioremap_nopost ioremap_nocache
> >
> > These are all the same as the default from asm-generic.h. Do we really
> > need these definitions in alpha, avr32, frv, ia64, x86?
>
> Those arches do not include asm-generic.h (I suppose for a good reason)

OK, that explains it. I'm not at all sure there's a good reason for
those arches not using asm-generic.h, but I haven't looked at the code
to see.

> but a definition is needed anyway if we want code using ioremap_nopost()
> to be unconditional. This is one way of doing it, there are others not
> sure they are any better, I am open to suggestions.

\
 
 \ /
  Last update: 2017-03-30 18:48    [W:0.083 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site