Messages in this thread | | | Date | Thu, 30 Mar 2017 12:06:36 +0100 | From | Piotr Sroka <> | Subject | RE: [v5 2/4] dt-bindings: mmc: add description of PHY delays for sdhci-cadence |
| |
Hi Masahiro
2017-03-22 16:30 Masahiro Yamada <yamada.masahiro@socionext.com>: > 2017-03-21 23:33 GMT+09:00 Piotr Sroka <piotrs@cadence.com>: > > DTS properties are used instead of fixed data > > because PHY settings can be different for different chips/boards. > > Add description of new DLL PHY delays. > > > > Signed-off-by: Piotr Sroka <piotrs@cadence.com> > > --- > > Changes for v2: > > - file was created in v2. It was a part of driver source file patch. > > - most delays were moved from dts file > > to data associated with an SoC specific compatible > > - description of delays was updated to be more clearly > > --- > > Changes for v3: > > - move all delays back to dts because they are also boards dependent > > - prefix all of the Cadence-specific properties with cdns prefix > > --- > > Changes for v4: > > - change the beginning of the commit subject > > --- > > Changes for v5: > > - change name of property to be consistent with timing modes > > available in Linux > > > As I gave Reviewed-by in v4 already, this looks good to me. > > > Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > > As I said before, > once you get Reviewed/Acked tags, > please include them in your later version. >
Ok. I will remember next time.
-- Best Regards Piotr Sroka
| |