Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 3 Mar 2017 18:44:27 +0200 | Subject | Re: [PATCH v5 2/4] iio: accel: adxl345: Use I2C regmap instead of direct I2C access |
| |
On Tue, Feb 28, 2017 at 4:37 AM, Eva Rachel Retuya <eraretuya@gmail.com> wrote: > Convert the driver to use regmap instead of I2C-specific functions. This > is done in preparation for splitting this driver into core and > I2C-specific code as well as introduction of SPI driver. > > Signed-off-by: Eva Rachel Retuya <eraretuya@gmail.com> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Okay, my another set of comments. > @@ -70,6 +76,7 @@ static int adxl345_read_raw(struct iio_dev *indio_dev, > { > struct adxl345_data *data = iio_priv(indio_dev);
> int ret; > + __le16 regval;
Reverse tree order, please.
__le16 regval; int ret;
> @@ -104,37 +112,50 @@ static int adxl345_probe(struct i2c_client *client, > { > struct adxl345_data *data; > struct iio_dev *indio_dev; > + struct device *dev; > + struct regmap *regmap;
> int ret; > + u32 regval;
Ditto.
> + > + regmap = devm_regmap_init_i2c(client, &adxl345_regmap_config); > + if (IS_ERR(regmap)) { > + dev_err(&client->dev, "Error initializing regmap: %d\n", > + (int)PTR_ERR(regmap));
I don't like explicit casting in such cases at all. Why not to use %ld? Same for the similar places in the series.
> - if (ret != ADXL345_DEVID) { > - dev_err(&client->dev, "Invalid device ID: %d\n", ret); > + if (regval != ADXL345_DEVID) { > + dev_err(dev, "Invalid device ID: %x, expected %x\n", > + regval, ADXL345_DEVID);
So, originally it was in decimal form. Does hex looks better or what is behind the change?
-- With Best Regards, Andy Shevchenko
| |