Messages in this thread | | | Date | Fri, 3 Mar 2017 14:29:07 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 2/2] Fix endiannes error |
| |
These patches look good but you need to resend with a correct subsystem prefix in the subject. It should be:
[PATCH 2/2] Staging: wlan-ng: Fix endiannes error
Hm... Also "endiannes" doesn't look like correct spelling. Just say "endian".
On Thu, Mar 02, 2017 at 09:30:12PM +0100, Adrien Descamps wrote: > sparse report fixed: > drivers/staging//wlan-ng//hfa384x_usb.c:3517:35: warning: restricted __be64 degrades to integer > drivers/staging//wlan-ng//hfa384x_usb.c:3517:33: warning: incorrect type in assignment (different base types) > drivers/staging//wlan-ng//hfa384x_usb.c:3517:33: expected restricted __be64 [usertype] mactime > drivers/staging//wlan-ng//hfa384x_usb.c:3517:33: got unsigned long long > > Computation on the value should be done when in machine format, not in big endian format. > Compile tested only.
Generally we like to put the "Compile tested only" bit under the --- cut off so that our patches look more confident and authoritative. ;)
> > Signed-off-by: Adrien Descamps <adrien.descamps@gmail.com> > ---
Put it here.
> drivers/staging/wlan-ng/hfa384x_usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
regards, dan carpenter
| |