Messages in this thread | | | Date | Wed, 29 Mar 2017 17:30:56 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH 3/4] selftests: ftrace: Add -l/--logdir option |
| |
On Wed, 29 Mar 2017 10:46:24 +0900 Namhyung Kim <namhyung@kernel.org> wrote:
> In my virtual machine setup, running ftracetest failed on creating > LOG_DIR on a read-only filesystem. It'd be convenient to provide an > option to specify a different directory as log directory. >
Looks good to me :)
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
> Cc: Masami Hiramatsu <mhiramat@kernel.org> > Cc: Steven Rostedt <rostedt@goodmis.org> > Cc: Shuah Khan <shuahkh@osg.samsung.com> > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > tools/testing/selftests/ftrace/ftracetest | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest > index 52e3c4df28d6..a8631d978725 100755 > --- a/tools/testing/selftests/ftrace/ftracetest > +++ b/tools/testing/selftests/ftrace/ftracetest > @@ -16,6 +16,7 @@ echo " -k|--keep Keep passed test logs" > echo " -v|--verbose Increase verbosity of test messages" > echo " -vv Alias of -v -v (Show all results in stdout)" > echo " -d|--debug Debug mode (trace all shell commands)" > +echo " -l|--logdir <dir> Save logs on the <dir>" > exit $1 > } > > @@ -64,6 +65,10 @@ parse_opts() { # opts > DEBUG=1 > shift 1 > ;; > + --logdir|-l) > + LOG_DIR=$2 > + shift 2 > + ;; > *.tc) > if [ -f "$1" ]; then > OPT_TEST_CASES="$OPT_TEST_CASES `abspath $1`" > -- > 2.12.0 >
-- Masami Hiramatsu <mhiramat@kernel.org>
| |