Messages in this thread | | | Date | Mon, 27 Mar 2017 19:23:54 -0700 | From | Darren Hart <> | Subject | Re: [PATCH] selftests/futex: Fix build error with OUTPUT variable |
| |
On Tue, Mar 28, 2017 at 11:19:25AM +1100, Michael Ellerman wrote: > Darren Hart <dvhart@infradead.org> writes: > > > The use of $$OUTPUT in the target shell commands resulted in an empty > > string followed by an absolute path for which mkdir failed: > > > > $ make -C tools/testing/selftests/futex > > make: Entering directory '/home/dvhart/source/linux/linux-pdx86/tools/testing/selftests/futex' > > Makefile:36: warning: overriding recipe for target 'clean' > > ../lib.mk:55: warning: ignoring old recipe for target 'clean' > > for DIR in functional; do \ > > BUILD_TARGET=$OUTPUT/$DIR; \ > > mkdir $BUILD_TARGET -p; \ > > make OUTPUT=$BUILD_TARGET -C $DIR all;\ > > done > > mkdir: cannot create directory ‘/functional’: Permission denied > > > > Replace $$OUTPUT with $(OUTPUT) when referring to the Makefile OUTPUT > > variable. The above make command now completes successfully. > > > > Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT") > > Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org> > > Cc: linux-kselftest@vger.kernel.org > > Cc: bamvor.zhangjian@huawei.com > > Cc: Shuah Khan <shuah@kernel.org> > > Cc: <stable@vger.kernel.org> # 4.10.x- > > The OUTPUT support only went into v4.11-rc1, so I don't see why you need > a stable tag?
Git spelunking failure on my part, you are correct. Please disregard the stable tag.
> > Change looks good though. >
Thank you for the review.
-- Darren Hart VMware Open Source Technology Center
| |