Messages in this thread | | | Date | Mon, 27 Mar 2017 09:56:31 -0700 | From | Brian Norris <> | Subject | Re: [PATCH 5/5] firmware: google memconsole: Add ARM/ARM64 support |
| |
Hi Thierry,
In case this wasn't obvious from the build report:
On Thu, Mar 23, 2017 at 10:04:29PM +0100, Thierry Escande wrote: > --- a/drivers/firmware/google/Kconfig > +++ b/drivers/firmware/google/Kconfig > @@ -1,6 +1,5 @@ > menuconfig GOOGLE_FIRMWARE > bool "Google Firmware Drivers" > - depends on X86
The build bots complained: you're relaxing the compile-time restriction here, so you should probably move it to the GOOGLE_SMI symbol, since that file uses X86 assembly.
> default n > help > These firmware drivers are used by Google's servers. They are > @@ -21,7 +20,7 @@ config GOOGLE_SMI > > config GOOGLE_COREBOOT_TABLE > tristate > - depends on GOOGLE_COREBOOT_TABLE_ACPI > + depends on GOOGLE_COREBOOT_TABLE_ACPI || GOOGLE_COREBOOT_TABLE_OF > > config GOOGLE_COREBOOT_TABLE_ACPI > tristate "Coreboot Table Access - ACPI" > @@ -33,6 +32,16 @@ config GOOGLE_COREBOOT_TABLE_ACPI > pointer is accessed through the ACPI "GOOGCB00" object. > If unsure say N. > > +config GOOGLE_COREBOOT_TABLE_OF > + tristate "Coreboot Table Access - Device Tree" > + depends on OF > + select GOOGLE_COREBOOT_TABLE > + help > + This option enable the coreboot_table module, which provide other > + firmware modules to access coreboot table. The coreboot table pointer > + is accessed through the device tree node /firmware/coreboot. > + If unsure say N. > + > config GOOGLE_MEMCONSOLE > tristate > depends on GOOGLE_MEMCONSOLE_X86_LEGACY || GOOGLE_MEMCONSOLE_COREBOOT
Brian
| |