Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH] net: netfilter: Remove multiple assignment. | Date | Mon, 27 Mar 2017 15:09:13 +0000 |
| |
From: Pablo Neira Ayuso > Sent: 27 March 2017 13:08 > On Sat, Mar 25, 2017 at 06:19:47PM +0530, Arushi Singhal wrote: > > This patch removes multiple assignments. > > Done using coccinelle. > > @@ > > identifier i1,i2; > > constant c; > > @@ > > - i1=i2=c; > > + i1=c; > > + i2=c; > > You have to explain why this is bad.
And your substituted code isn't equivalent. The correct replacement is: i2 = c; i1 = i2;
David
| |