lkml.org 
[lkml]   [2017]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3 1/3] crypto: hw_random - Add new Exynos RNG driver
Date
Am Sonntag, 26. März 2017, 18:46:02 CEST schrieb PrasannaKumar Muralidharan:

Hi Krzysztof,

> >> > + if (slen < EXYNOS_RNG_SEED_SIZE) {
> >> > + dev_warn(rng->dev, "Seed too short (only %u bytes)\n",
> >> > slen); + return -EINVAL;
> >> > + }
> >>
> >> Will it be helpful to print the required seed size?
> >
> > It is in /proc/crypto... It is not a problem to print it but isn't that
> > redundant?
>
> Not necessary if it is already available.

Maybe the dev_warn should be removed. Note, unprivileged user space can
trigger this warning by simply invoking the seeding operation over and over
again with an insufficient seed size. This would clutter the log.

Ciao
Stephan

\
 
 \ /
  Last update: 2017-03-26 19:06    [W:0.048 / U:12.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site