lkml.org 
[lkml]   [2017]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5] Input: ambakmi - Convert to use devm_*()
    On Sun, Mar 26, 2017 at 03:50:24PM +0100, Russell King - ARM Linux wrote:
    > On Sun, Mar 26, 2017 at 10:41:50PM +0800, Leo Yan wrote:
    > > Convert driver to use devm_*() APIs so rely on driver model core layer
    > > to manage resources. This eliminates error path boilerplate and makes
    > > code neat.
    > >
    > > This patch also fixes the memory leakage for 'kmi->io' when remove
    > > module.
    >
    > No, it is not leaked, in fact, your patch introduces a use-after-free
    > bug.
    >
    > kmi->io is of type "struct serio", and this structure has an embedded
    > "struct device". The lifetime of any structure containing a "struct
    > device" is controlled by the lifetime of the struct device.
    >
    > Once serio_register_port() has been called on it, it is up to the
    > serio layer to free this structure.
    >
    > Therefore, your patch creates a bug, and so it gets a NAK. There is no
    > resource leakage here.

    Thanks for reviewing. Now I understood and please ignore this patch
    and patch 0005.

    Thanks,
    Leo Yan

    \
     
     \ /
      Last update: 2017-03-26 17:31    [W:2.918 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site