lkml.org 
[lkml]   [2017]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [RFC PATCH 1/1] tpm_tis: convert to using locality callbacks


----- Original Message -----
> From: "Jason Gunthorpe" <jgunthorpe@obsidianresearch.com>
> To: "Jerry Snitselaar" <jsnitsel@redhat.com>
> Cc: tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, "Peter Huewe" <peterhuewe@gmx.de>, "Jarkko
> Sakkinen" <jarkko.sakkinen@linux.intel.com>, "Marcel Selhorst" <tpmdd@selhorst.net>
> Sent: Sunday, March 26, 2017 1:36:28 PM
> Subject: Re: [RFC PATCH 1/1] tpm_tis: convert to using locality callbacks
>
> On Sat, Mar 25, 2017 at 01:05:21PM -0700, Jerry Snitselaar wrote:
>
> > @@ -672,7 +658,7 @@ void tpm_tis_remove(struct tpm_chip *chip)
> > interrupt = 0;
> >
> > tpm_tis_write32(priv, reg, ~TPM_GLOBAL_INT_ENABLE & interrupt);
> > - release_locality(chip, priv->locality, 1);
> > + release_locality(chip, priv->locality);
>
> Why is this done during remove? The tpm core should now keep things so
> that there is not a requested locality except during command so execution
> we should not get here with a requested locality..
>
> Jason
>

You're right, this call should be dropped. With release_locality always releasing
now it shouldn't have a locality when going into remove. I'll drop this in v2.

Thanks,
Jerry

\
 
 \ /
  Last update: 2017-03-27 00:41    [W:0.066 / U:5.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site