lkml.org 
[lkml]   [2017]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 15/30] tpm_tis: Use devm_free_irq not free_irq
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

    commit 727f28b8ca24a581c7bd868326b8cea1058c720a upstream.

    The interrupt is always allocated with devm_request_irq so it
    must always be freed with devm_free_irq.

    Fixes: 448e9c55c12d ("tpm_tis: verify interrupt during init")
    Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
    Acked-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
    Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
    Tested-by: Martin Wilck <Martin.Wilck@ts.fujitsu.com>
    Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
    Acked-by: Peter Huewe <peterhuewe@gmx.de>
    Cc: Sumit Semwal <sumit.semwal@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/char/tpm/tpm_tis.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/char/tpm/tpm_tis.c
    +++ b/drivers/char/tpm/tpm_tis.c
    @@ -401,7 +401,7 @@ static void disable_interrupts(struct tp
    iowrite32(intmask,
    chip->vendor.iobase +
    TPM_INT_ENABLE(chip->vendor.locality));
    - free_irq(chip->vendor.irq, chip);
    + devm_free_irq(chip->pdev, chip->vendor.irq, chip);
    chip->vendor.irq = 0;
    }


    \
     
     \ /
      Last update: 2017-03-24 19:15    [W:4.110 / U:0.312 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site