lkml.org 
[lkml]   [2017]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 5/8] regulator: anatop: fix min dropout for bypass mode
On Wed, Mar 22, 2017 at 06:53:07PM +0200, Leonard Crestez wrote:

> + if (anatop_reg->bypass)
> + anatop_reg->rdesc.min_dropout_uV = 0;
> + else
> + anatop_reg->rdesc.min_dropout_uV = LDO_MIN_DROPOUT_UV;

No, this is completely broken - you can't expect to randomly change hthe
regulator description at runtime behind the back of the framework and
expect things to work. If there is a need to do this we need an
interface for getting the current value and a way to notify of changes.

That said I would not expect the dropout voltage to be considered at
all when the regulator is bypassed, since the regulator is not
regulating it doesn't need any headroom.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-03-24 13:56    [W:0.442 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site