Messages in this thread | | | From | Pranay Srivastava <> | Date | Fri, 24 Mar 2017 15:44:02 +0530 | Subject | Re: [[RESEND]PATCH staging/speakup v3 3/3] use speakup_allocate as per required context |
| |
On Fri, Mar 24, 2017 at 2:13 PM, Greg KH <greg@kroah.com> wrote: > On Fri, Mar 24, 2017 at 02:07:11PM +0530, Pranay Kr. Srivastava wrote: >> speakup_allocate used GFP_ATOMIC for allocations >> even while during initialization due to it's use >> in notifier call. > > Is that a problem?
No that's the way it should be. I was just trying to say that allocation should be context based[?]. If we can be lenient then that's better[?]
> >> Pass GFP_ flags as well to speakup_allocate depending >> on the context it is called in. > > At init, we should be fine to use GFP_ATOMIC, so is this change really > needed? > > thanks, > > greg k-h
-- ---P.K.S
| |