lkml.org 
[lkml]   [2017]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] x86: Implement __WARN using UD0
On Wed, Mar 22, 2017 at 09:47:06AM +0100, Peter Zijlstra wrote:
>
> A little like so then.
>
> ---
> Subject: x86: Implement __WARN using UD0
> From: Peter Zijlstra <peterz@infradead.org>
> Date: Thu Feb 2 14:43:51 CET 2017
>
> By using "UD0" for WARNs we remove the function call and its possible
> __FILE__ and __LINE__ immediate arguments from the instruction stream.
>
> Total image size will not change much, what we win in the instruction
> stream we'll loose because of the __bug_table entries. Still, saves on
> I$ footprint and the total image size does go down a bit.
>
> text data bss dec hex filename
> 10702123 4530992 843776 16076891 f5505b defconfig-build/vmlinux.0
> 10682460 4530992 843776 16057228 f5038c defconfig-build/vmlinux.1
>
> (um didn't seem to use GENERIC_BUG at all, so remove it)
>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Richard Weinberger <richard.weinberger@gmail.com>
> Cc: Arjan van de Ven <arjan@linux.intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Josh Poimboeuf <jpoimboe@redhat.com>
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>

Looks good, thanks!

Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>

--
Josh

\
 
 \ /
  Last update: 2017-03-22 15:19    [W:0.049 / U:0.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site