lkml.org 
[lkml]   [2017]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/5] clk: meson: Add support for parameters for specific PLLs
From
Date
On 03/22/2017 12:43 AM, Michael Turquette wrote:
> Quoting Neil Armstrong (2017-03-13 06:26:40)
[..]
>>
>> p = &pll->n;
>> - ret = meson_clk_pll_wait_lock(pll, p);
>> + /* If unreset_for_lock is provided, remove the reset bit here */
>> + if (pll->params.unreset_for_lock) {
>
> Small nitpick, but I find "unreset" to be confusing. Since 'reset' here
> is a bit that can be set and unset, maybe use clear_reset_for_lock
> instead?
>
> Regards,
> Mike
>

You are right, I'll rename it.

Neil

\
 
 \ /
  Last update: 2017-03-22 11:24    [W:0.062 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site