lkml.org 
[lkml]   [2017]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.10 62/63] crypto: powerpc - Fix initialisation of crc32c context
    Date
    4.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Daniel Axtens <dja@axtens.net>

    commit aa2be9b3d6d2d699e9ca7cbfc00867c80e5da213 upstream.

    Turning on crypto self-tests on a POWER8 shows:

    alg: hash: Test 1 failed for crc32c-vpmsum
    00000000: ff ff ff ff

    Comparing the code with the Intel CRC32c implementation on which
    ours is based shows that we are doing an init with 0, not ~0
    as CRC32c requires.

    This probably wasn't caught because btrfs does its own weird
    open-coded initialisation.

    Initialise our internal context to ~0 on init.

    This makes the self-tests pass, and btrfs continues to work.

    Fixes: 6dd7a82cc54e ("crypto: powerpc - Add POWER8 optimised crc32c")
    Cc: Anton Blanchard <anton@samba.org>
    Signed-off-by: Daniel Axtens <dja@axtens.net>
    Acked-by: Anton Blanchard <anton@samba.org>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/powerpc/crypto/crc32c-vpmsum_glue.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/arch/powerpc/crypto/crc32c-vpmsum_glue.c
    +++ b/arch/powerpc/crypto/crc32c-vpmsum_glue.c
    @@ -52,7 +52,7 @@ static int crc32c_vpmsum_cra_init(struct
    {
    u32 *key = crypto_tfm_ctx(tfm);

    - *key = 0;
    + *key = ~0;

    return 0;
    }

    \
     
     \ /
      Last update: 2017-03-20 19:13    [W:3.829 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site